chore: change the resolution of reply latency to measurement to ns #6092
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
Pr3
branch
2 times, most recently
from
b563ac7 to
f53b931
Compare
romange
commented
Nov 21, 2025
romange
commented
Nov 21, 2025
| """Make sure reply aggregations reduce reply counts for common cases""" | ||
|
|
||
| async def get_reply_count(): | ||
| return (await async_client.info("STATS"))["reply_count"] |
Collaborator
Author
There was a problem hiding this comment.
before: the info call intervened with the test, now we scrape /metrics
dranikpg
reviewed
Nov 21, 2025
dranikpg
reviewed
Nov 21, 2025
Also, fix test_reply_count that did not really tested command due to missed await statements. Signed-off-by: Roman Gershman <[email protected]>
dranikpg
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align test_reply_count to use /metrics for fetching the
reply_countcounter.